feat(grpc): Support span streaming#6204
feat(grpc): Support span streaming#6204alexander-alderman-webb wants to merge 13 commits intomasterfrom
Conversation
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 6.61s All tests are passing successfully. ❌ Patch coverage is 2.04%. Project has 15099 uncovered lines. Files with missing lines (5)
Generated by Codecov Action |
sentrivana
left a comment
There was a problem hiding this comment.
LGTM. Can you please also add parent_span=None to sentry_sdk.traces.start_span calls where there were transactions previously? 🙏🏻
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9b14623. Configure here.
|
|
||
| spans = [item["payload"] for item in items if item["type"] == "span"] | ||
|
|
||
| assert spans[0]["trace_id"] == spans[1]["trace_id"] |
There was a problem hiding this comment.
Trace continuity assertion tests same-process spans only
Medium Severity
The span_streaming path of test_grpc_client_and_servers_interceptors_integration asserts spans[0]["trace_id"] == spans[1]["trace_id"], but both spans[0] and spans[1] are server-side spans (the inner "test" span and the GRPC_SERVER span, ordered by finish time). This is trivially true since they originate from the same process. The original test verified that the server transaction's trace_id matched the client transaction's trace_id, confirming distributed trace propagation works. The new assertion no longer validates cross-process trace continuity — the core purpose of this test.
Reviewed by Cursor Bugbot for commit 9b14623. Configure here.


Description
In the streaming path, use
rpc.methodinstead ofmethodrpc.response.status_codeinstead ofcodeDropped attributes:
Adapting Tests
sedcommands used for converting transaction context managers:sed commands used for converting specific attributes:
sedcommands used for converting event capture:sedcommands used for convertingop:sedcommands used for converting origin:sedcommands used for convertingdescription:sedcommands used for convertingdatatoattributes:sedcommands for converting trace id:other test changes:
Issues
Closes #6027
Reminders
tox -e linters.feat:,fix:,ref:,meta:)